Block hash or meta hash in transition mapping ? #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Brechtpd i commented your name where i'd need help. Currently it verifies everything.. So for example it verifies the first block after it is proposed.
First because of the blockHash, while i use metaHash, but also, since i used this: bytes32 blockHash = blk.metaHash;... i dont get why the first block
state.transitions[blockId][blockHash].blockHash == bytes32(0)
equals to true now.. (since i set themetaHash
as blockHash)