Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block hash or meta hash in transition mapping ? #18

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

adaki2004
Copy link

@adaki2004 adaki2004 commented Jul 4, 2024

@Brechtpd i commented your name where i'd need help. Currently it verifies everything.. So for example it verifies the first block after it is proposed.

First because of the blockHash, while i use metaHash, but also, since i used this: bytes32 blockHash = blk.metaHash;... i dont get why the first block state.transitions[blockId][blockHash].blockHash == bytes32(0) equals to true now.. (since i set the metaHash as blockHash)

            if (
state.tansitions[blockId][blockHash].blockHash == bytes32(0)
                    || block.timestamp < state.transitions[blockId][blockHash].verifiableAfter
            ) {
                break;
            }

@adaki2004 adaki2004 merged commit 317107c into first_simple_tests Jul 5, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant